Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(h5): 修复h5下的pageScrollTo函数功能 #8050

Merged
merged 2 commits into from
Dec 12, 2020
Merged

fix(h5): 修复h5下的pageScrollTo函数功能 #8050

merged 2 commits into from
Dec 12, 2020

Conversation

zhaoguoweiLLHC
Copy link
Contributor

@zhaoguoweiLLHC zhaoguoweiLLHC commented Nov 17, 2020 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)

  1. 增加h5下的pageScrollTo函数的selector参数支持。
  2. 修复h5下的pageScrollTo函数的tabbar判断方式有误导致的滚动异常问题。

这个 PR 是什么类型? (至少选择一个)

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

@zhaoguoweiLLHC zhaoguoweiLLHC changed the title fix(h5): 修复h5下的pageScrollTo函数的selector参数支持问题 fix(h5): 修复h5下的pageScrollTo函数功能 Nov 21, 2020
This was referenced Nov 23, 2020
Closed
Closed
@taro-bot2 taro-bot2 bot mentioned this pull request Dec 5, 2020
Closed
@Chen-jj Chen-jj requested a review from ZakaryCode December 11, 2020 11:45
@Chen-jj Chen-jj added the V-3 Version - 3.x label Dec 11, 2020
@taro-bot2 taro-bot2 bot mentioned this pull request Dec 12, 2020
Closed
ZakaryCode
ZakaryCode approved these changes Dec 12, 2020
View reviewed changes
Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献，pull-to-refresh 应该也有同样的问题，有空可以帮忙一并修复下 😊

@ZakaryCode ZakaryCode merged commit e07b9ff into NervJS:next Dec 12, 2020
@ZakaryCode ZakaryCode mentioned this pull request Dec 12, 2020
Closed
@zhaoguoweiLLHC zhaoguoweiLLHC deleted the fix/pageScrollTo_h5 branch December 14, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZakaryCode ZakaryCode ZakaryCode approved these changes

Assignees
No one assigned
Labels
V-3 Version - 3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhaoguoweiLLHC @ZakaryCode @Chen-jj